[5] add2scheduler-updatenotification #40788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
reviewed
Jun 18, 2023
joomla-cms-bot
added
Language Change
richard67
reviewed
Jun 18, 2023
richard67
reviewed
Jun 18, 2023
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
reviewed
Jun 18, 2023
richard67
reviewed
Jun 18, 2023
richard67
reviewed
Jun 25, 2023
richard67
reviewed
Jun 25, 2023
richard67
reviewed
Jun 25, 2023
|
@alikon Besides my review suggestions following is missing:
Point 2 is only needed when the functionality is enabled on a new installation by default, like it is here and for the logrotation. For things which are not enabled by default on a new installation, like e.g. the privacy consents, we would not need that. |
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
@heelc29 The PR is ready for testing. Code style error is not related to the PR but to the current 5.0-dev branch. Could you test again? Testing instructions can be found in the description of this PR. Thanks in advance. |
richard67
reviewed
Sep 3, 2023
|
I have tested this item ✅ successfully on c3ff33a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40788. |
4 tasks
4 tasks
|
thank you all for your help |
2 tasks
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Nov 2, 2023
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Nov 2, 2023
Kostelano
added a commit
to Joomla-Ukraine/uk-UA
that referenced
this pull request
Nov 4, 2023
Kostelano
added a commit
to Joomla-Ukraine/uk-UA
that referenced
this pull request
Nov 4, 2023
….ini Удалено в Joomla 5, joomla/joomla-cms#40788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
move update notification from system plguin to scheduler/task plugin
Testing Instructions
Hint: The execution times and hours shown for tasks in the administrator are in the UTC timezone.
New installation
Make a new installation with this PR applied.
Check if there is an enabled task scheduler plugin "Task - Joomla! Update Notification".
Check if there is an enabled scheduled task "UpdateNotification" using that plugin.
Check that the new task shall run every 24 hours at the hour when the Joomla installation was made.
Update
On a Joomla 4.4-dev version or 4.4.0 alpha 4, note the endabled status and the configuration parameters of the "System - Joomla! Update Notification" plugin.
Now either disable that plugin or enable it and optionally change some of the configuration parameters to a value different to the default.
Update to the patched package or custom update URL created by Drone for this PR.
Check if the "System - Joomla! Update Notification" plugin has been uninstalled.
Check if there is a task scheduler plugin "Task - Joomla! Update Notification".
Check enabled status and configuration parameters of that plugin.
Check if there is a scheduled task "UpdateNotification" using that plugin. If so, check the configuration parameters, too.
Repeat the previous steps with different endabled status and configuration parameters of the "System - Joomla! Update Notification" plugin.
Actual result BEFORE applying this Pull Request
Notification on available Joomla updates is done with the "System - Joomla! Update Notification" plugin.
Expected result AFTER applying this Pull Request
New installation
The "Task - Joomla! Update Notification" plugin is enabled, and a scheduled task "UpdateNotification" is enabled to run every 24 hours at the hour of the Joomla installation.
Update
The "System - Joomla! Update Notification" plugin has been uninstalled by the update.
A new task scheduler plugin "Task - Joomla! Update Notification" has been created and is enabled.
If the old "System - Joomla! Update Notification" plugin was enabled before the update, a new scheduled task "UpdateNotification" has been created and is enabled.
The configuration parameters "Super User Emails" and "Email Language" of that task are set according to the old system plugin's parameters.
The interval hours is equal to the cache timeout parameter in the configuration option of the "Installer" component (com_installer).
If the old "System - Joomla! Update Notification" plugin was disabled before the update, there is no task for that plugin.
Link to documentations
Please select:
Documentation link for docs.joomla.org: link will be added later
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed